Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-21.0] fixes bugs around expression precedence and LIKE (#16934) #16947

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[release-21.0] fixes bugs around expression precedence and LIKE (#16934) #16947

merged 1 commit into from
Oct 14, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 14, 2024

Description

This is a backport of #16934

@vitess-bot @GuptaManan100 @vitess-bot
fixes bugs around expression precedence and LIKE (#16934)
cc5c81a 
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner October 14, 2024 09:01
@vitess-bot vitess-bot bot added the Type: Bug label Oct 14, 2024
@vitess-bot vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.0 milestone Oct 14, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.44%. Comparing base (34df88f) to head (cc5c81a).
Report is 1 commits behind head on release-21.0.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/fn_string.go 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-21.0   #16947      +/-   ##
================================================
+ Coverage         69.42%   69.44%   +0.01%     
================================================
  Files              1570     1570              
  Lines            203814   203801      -13     
================================================
+ Hits             141506   141532      +26     
+ Misses            62308    62269      -39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitess-bot vitess-bot mentioned this pull request Oct 14, 2024
Closed
35 tasks
@rohit-nayak-ps rohit-nayak-ps merged commit fe6a6ce into release-21.0 Oct 14, 2024
195 of 196 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the backport-16934-to-release-21.0 branch October 14, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: Query Serving Type: Bug
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@systay @rohit-nayak-ps